docs: updates architecture diagram and test instructions in README #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #70 +/- ##
=========================================
Coverage 56.26% 56.26%
Complexity 41 41
=========================================
Files 20 20
Lines 375 375
Branches 18 18
=========================================
Hits 211 211
Misses 160 160
Partials 4 4
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
|
||
| To test your image using the docker-compose setup follow the steps: | ||
|
|
||
| - Commit you changes to a branch say `graphql-service-test`. |
Contributor
There was a problem hiding this comment.
nit: We describe how to test via docker compose in a section called "Testing image" and via helm in one called "Helm setup". I think It would make more sense to break it down into two sections under "Testing image" like "With docker-compose" and "With helm"
Co-authored-by: Aaron Steinfeld <45047841+aaron-steinfeld@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
aaron-steinfeld
approved these changes
Feb 10, 2021
skjindal93
pushed a commit
that referenced
this pull request
Jun 21, 2024
* Added config for gateway gRPC client deadline * Spotless apply * Changed gateway-service client timeout unit to java.time.Duration and added fallback configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR,
Testing
NA
Checklist:
Documentation